admin switch: Allow switching just remote names

This is a followup to the previous commit; for the installation media
case we want to keep the current origin ref, and only switch remotes.

diff --git a/src/ostree/ot-admin-builtin-switch.c b/src/ostree/ot-admin-builtin-switch.c
index ad02b90c8672dc0a98bd4e513a165e7e046667fe..44861e52dd68bcc27ee22aa35c19e5a306ad8322 100644 (file)
--- a/src/ostree/ot-admin-builtin-switch.c
+++ b/src/ostree/ot-admin-builtin-switch.c
@@ -78,8 +78,6 @@ ot_admin_builtin_switch (int argc, char **argv, OstreeSysroot *sysroot, GCancell
     }
 
   new_provided_refspec = argv[1];
-  if (!ostree_parse_refspec (new_provided_refspec, &new_remote, &new_ref, error))
-    goto out;
 
   if (!ostree_sysroot_load (sysroot, cancellable, error))
     goto out;
@@ -95,11 +93,24 @@ ot_admin_builtin_switch (int argc, char **argv, OstreeSysroot *sysroot, GCancell
   if (!ostree_parse_refspec (origin_refspec, &origin_remote, &origin_ref, error))
     goto out;
 
+  /* Allow just switching remotes */
+  if (g_str_has_suffix (new_provided_refspec, ":"))
+    {
+      new_remote = g_strdup (new_provided_refspec);
+      new_remote[strlen(new_remote)-1] = '\0';
+      new_ref = g_strdup (origin_ref);
+    }
+  else
+    {
+      if (!ostree_parse_refspec (new_provided_refspec, &new_remote, &new_ref, error))
+        goto out;
+    }
+  
   if (!new_remote)
-    new_refspec = g_strconcat (origin_remote, ":", new_provided_refspec, NULL);
+    new_refspec = g_strconcat (origin_remote, ":", new_ref, NULL);
   else
-    new_refspec = g_strdup (new_provided_refspec);
-
+    new_refspec = g_strconcat (new_remote, ":", new_ref, NULL);
+  
   if (strcmp (origin_refspec, new_refspec) == 0)
     {
       g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,

diff --git a/tests/test-admin-deploy-switch.sh b/tests/test-admin-deploy-switch.sh
index f791348ffbafdf32f619f07555ea705b05c7d4b9..0516e5c251b908ed5b010a4f3fad52ffa189b0b0 100644 (file)
--- a/tests/test-admin-deploy-switch.sh
+++ b/tests/test-admin-deploy-switch.sh
@@ -50,3 +50,7 @@ ostree admin --sysroot=sysroot status > status.txt
 assert_file_has_content status.txt anothertestos
 
 echo "ok switch remotes"
+
+ostree admin --sysroot=sysroot switch --os=testos testos:
+
+echo "ok switch remote only"